Skip to content

Conversation

@MBaesken
Copy link
Member

@MBaesken MBaesken commented Oct 16, 2025


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8369563 needs maintainer approval

Issue

  • JDK-8369563: Gtest dll_address_to_function_and_library_name has issues with stripped pdb files (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u.git pull/316/head:pull/316
$ git checkout pull/316

Update a local copy of the PR:
$ git checkout pull/316
$ git pull https://git.openjdk.org/jdk25u.git pull/316/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 316

View PR using the GUI difftool:
$ git pr show -t 316

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u/pull/316.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 16, 2025

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 16, 2025

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8369563: Gtest dll_address_to_function_and_library_name has issues with stripped pdb files

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 34 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 98e1d2fab123befa78342ba53b76a560dddd6385 8369563: Gtest dll_address_to_function_and_library_name has issues with stripped pdb files Oct 16, 2025
@openjdk
Copy link

openjdk bot commented Oct 16, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Oct 16, 2025
@openjdk
Copy link

openjdk bot commented Oct 16, 2025

⚠️ @MBaesken This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 16, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 16, 2025

Webrevs

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Oct 20, 2025
@MBaesken
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Oct 24, 2025

Going to push as commit 9bafce8.
Since your change was applied there have been 38 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 24, 2025
@openjdk openjdk bot closed this Oct 24, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 24, 2025
@openjdk
Copy link

openjdk bot commented Oct 24, 2025

@MBaesken Pushed as commit 9bafce8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant